Commit ec6186ac authored by cq990612's avatar cq990612

优化代码结构

parent c73eae43
...@@ -15,10 +15,10 @@ ...@@ -15,10 +15,10 @@
<where> <where>
<if test="projectIds !=null and projectIds.size()>0"> <if test="projectIds !=null and projectIds.size()>0">
<if test="startDate !=null"> <if test="startDate !=null">
AND oc.change_date >= #{startDate} AND DATE_FORMAT(oc.change_date, '%Y%m%d') >= DATE_FORMAT(#{startDate} ,'%Y%m%d')
</if> </if>
<if test="endDate !=null"> <if test="endDate !=null">
AND oc.change_date &lt;= #{endDate} AND DATE_FORMAT(oc.change_date, '%Y%m%d') &lt;= DATE_FORMAT(#{endDate} ,'%Y%m%d')
</if> </if>
<if test="userName !=null"> <if test="userName !=null">
AND (u2.name like concat('%',#{userName},'%') AND (u2.name like concat('%',#{userName},'%')
...@@ -44,10 +44,10 @@ ...@@ -44,10 +44,10 @@
</foreach> </foreach>
</if> </if>
<if test="startDate !=null"> <if test="startDate !=null">
AND oc.change_date >= #{startDate} AND DATE_FORMAT(oc.change_date, '%Y%m%d') >= DATE_FORMAT(#{startDate} ,'%Y%m%d')
</if> </if>
<if test="endDate !=null"> <if test="endDate !=null">
AND oc.change_date &lt;= #{endDate} AND DATE_FORMAT(oc.change_date, '%Y%m%d') &lt;= DATE_FORMAT(#{endDate} ,'%Y%m%d')
</if> </if>
<if test="userName !=null"> <if test="userName !=null">
AND (u2.name like concat('%',#{userName},'%') AND (u2.name like concat('%',#{userName},'%')
......
...@@ -291,17 +291,18 @@ ...@@ -291,17 +291,18 @@
</resultMap> </resultMap>
<select id="getOrderChangeTypeDtos" resultMap="orderChangeType"> <select id="getOrderChangeTypeDtos" resultMap="orderChangeType">
select p.type,t.name 'type_name',p.id 'project_id',p.project_name,up.user_id,u.name 'user_name',u.dept_id,d.dept_name select p.type,t.name 'type_name',p.id 'project_id',p.project_name,up.user_id,u.name 'user_name',u.dept_id,d.dept_name,d1.id,d1.dept_name
from work_project p LEFT JOIN work_user_project up on p.id = up.project_id from work_project p LEFT JOIN work_user_project up on p.id = up.project_id
LEFT JOIN work_user u ON up.user_id = u.id LEFT JOIN work_user u ON up.user_id = u.id
LEFT JOIN work_dept d ON d.id = u.dept_id LEFT JOIN (select id,dept_name,sort FROM work_dept)d1 ON d1.id = p.dept_id
LEFT JOIN work_type t ON p.type = t.id LEFT JOIN work_dept d ON d.id = u.dept_id
LEFT JOIN work_type t ON p.type = t.id
<where> <where>
<if test="userId !=null"> <if test="userId !=null">
AND p.manager_id = #{userId} AND p.manager_id = #{userId}
</if> </if>
</where> </where>
ORDER BY t.sort,d1.sort,p.id
</select> </select>
......
...@@ -9,11 +9,14 @@ import java.util.List; ...@@ -9,11 +9,14 @@ import java.util.List;
* @QQ1799796883 * @QQ1799796883
*/ */
@Data @Data
public class OrderChangeProjectDto { public class OrderChangeProjectDto{
private Integer projectId; private Integer projectId;
private String projectName; private String projectName;
private List<DeptUserDto> deptUserDtos; private List<DeptUserDto> deptUserDtos;
} }
...@@ -16,7 +16,7 @@ import lombok.experimental.Accessors; ...@@ -16,7 +16,7 @@ import lombok.experimental.Accessors;
@Accessors(chain = true) @Accessors(chain = true)
@EqualsAndHashCode(callSuper = false) @EqualsAndHashCode(callSuper = false)
@ApiModel(value="ProjectManagerDto", description="可审批的项目") @ApiModel(value="ProjectManagerDto", description="可审批的项目")
public class ProjectManagerDto implements Comparable<ProjectManagerDto>{ public class ProjectManagerDto implements Comparable<ProjectManagerDto> {
@ApiModelProperty(name = "id",value = "主键id") @ApiModelProperty(name = "id",value = "主键id")
@TableId(value = "id", type = IdType.AUTO) @TableId(value = "id", type = IdType.AUTO)
...@@ -40,4 +40,6 @@ public class ProjectManagerDto implements Comparable<ProjectManagerDto>{ ...@@ -40,4 +40,6 @@ public class ProjectManagerDto implements Comparable<ProjectManagerDto>{
return -this.pendingApprovalTimes.compareTo(o.pendingApprovalTimes); return -this.pendingApprovalTimes.compareTo(o.pendingApprovalTimes);
} }
} }
...@@ -141,5 +141,5 @@ public interface WorkTimeOrderService { ...@@ -141,5 +141,5 @@ public interface WorkTimeOrderService {
Boolean updateOrderChange(OrderChangeVo vo); Boolean updateOrderChange(OrderChangeVo vo);
Boolean deleteOrderChange(Integer workId, Integer operator); Boolean deleteOrderChange(Integer workId, Integer operator,String changeReason);
} }
...@@ -29,10 +29,7 @@ import org.springframework.transaction.annotation.Transactional; ...@@ -29,10 +29,7 @@ import org.springframework.transaction.annotation.Transactional;
import org.springframework.util.CollectionUtils; import org.springframework.util.CollectionUtils;
import java.math.BigDecimal; import java.math.BigDecimal;
import java.util.ArrayList; import java.util.*;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.stream.Collectors; import java.util.stream.Collectors;
/** /**
......
...@@ -351,7 +351,6 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService { ...@@ -351,7 +351,6 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService {
if (CollectionUtils.isEmpty(ts)) { if (CollectionUtils.isEmpty(ts)) {
throw new BaseCustomException(BASE_RESP_CODE_ENUM.INPUT_PARAM_IS_NULL); throw new BaseCustomException(BASE_RESP_CODE_ENUM.INPUT_PARAM_IS_NULL);
} }
ts.forEach(t ->{ ts.forEach(t ->{
if (t instanceof WorkTimeOrder) { if (t instanceof WorkTimeOrder) {
list.add((WorkTimeOrder) t); list.add((WorkTimeOrder) t);
...@@ -1177,7 +1176,6 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService { ...@@ -1177,7 +1176,6 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService {
workTimeOrders.removeIf(workTimeOrder -> workTimeOrder.getWorkId().equals(vo.getWorkId())); workTimeOrders.removeIf(workTimeOrder -> workTimeOrder.getWorkId().equals(vo.getWorkId()));
} }
totalTime = timeNotEight(totalTime, workTimeOrders); totalTime = timeNotEight(totalTime, workTimeOrders);
System.out.println("3333333333");
// 4.判断工时类型是否重复 // 4.判断工时类型是否重复
List<WorkTimeOrder> workTimeOrderList = new ArrayList<>(8); List<WorkTimeOrder> workTimeOrderList = new ArrayList<>(8);
if (!CollectionUtils.isEmpty(workTimeOrders)) { if (!CollectionUtils.isEmpty(workTimeOrders)) {
...@@ -1220,9 +1218,9 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService { ...@@ -1220,9 +1218,9 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService {
@Transactional @Transactional
@Override @Override
public Boolean deleteOrderChange(Integer workId, Integer operator) { public Boolean deleteOrderChange(Integer workId, Integer operator,String changeReason) {
log.info("WorkTimeOrderServiceImpl[]deleteOrderChange[]input.param.workId:{},operator:{}" + workId, operator); log.info("WorkTimeOrderServiceImpl[]deleteOrderChange[]input.param.workId:{},operator:{},changeReason:{}" + workId, operator,changeReason);
if (null == workId || null == operator) { if (null == workId || null == operator || StringUtils.isBlank(changeReason)) {
throw new BaseCustomException(BASE_RESP_CODE_ENUM.INPUT_PARAM_IS_NULL); throw new BaseCustomException(BASE_RESP_CODE_ENUM.INPUT_PARAM_IS_NULL);
} }
if (!UserRoleLevelUtils.isManagerLevel(operator, LevelEnum.WORKORDER_CHANGEMANAGEMENT.getLevelName())) { if (!UserRoleLevelUtils.isManagerLevel(operator, LevelEnum.WORKORDER_CHANGEMANAGEMENT.getLevelName())) {
...@@ -1260,7 +1258,7 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService { ...@@ -1260,7 +1258,7 @@ public class WorkTimeOrderServiceImpl implements WorkTimeOrderService {
throw new BaseCustomException(BASE_RESP_CODE_ENUM.FAILEDTO_DELETE_DATA); throw new BaseCustomException(BASE_RESP_CODE_ENUM.FAILEDTO_DELETE_DATA);
} }
} }
vo.setChangeReason(changeReason);
// 增加记录 // 增加记录
addWorkOrderChange(OrderChangeEnum.DELETE.getContent(), vo); addWorkOrderChange(OrderChangeEnum.DELETE.getContent(), vo);
......
...@@ -205,12 +205,13 @@ public class WorkTimeOrderController extends BaseController { ...@@ -205,12 +205,13 @@ public class WorkTimeOrderController extends BaseController {
@ApiOperation(value = "删除工单",notes = "删除工单",httpMethod = "DELETE") @ApiOperation(value = "删除工单",notes = "删除工单",httpMethod = "DELETE")
@ApiImplicitParams({ @ApiImplicitParams({
@ApiImplicitParam(name = "workId",value = "工单id",dataType = "int",required = true), @ApiImplicitParam(name = "workId",value = "工单id",dataType = "int",required = true),
@ApiImplicitParam(name = "operator",value = "操作者",dataType = "int",required = true) @ApiImplicitParam(name = "operator",value = "操作者",dataType = "int",required = true),
@ApiImplicitParam(name = "changeReason",value = "删除理由",dataType = "String",required = true)
}) })
@DeleteMapping("/deleteOrderChange") @DeleteMapping("/deleteOrderChange")
public Result deleteOrderChange(Integer workId,Integer operator) { public Result deleteOrderChange(Integer workId,Integer operator,String changeReason) {
log.info("WorkTimeOrderController[]deleteOrderChange[]input.param.workId:{},operator:{}" + workId,operator); log.info("WorkTimeOrderController[]deleteOrderChange[]input.param.workId:{},operator:{},changeReason:{}" + workId,operator,changeReason);
Boolean aBoolean = workTimeOrderService.deleteOrderChange(workId, operator); Boolean aBoolean = workTimeOrderService.deleteOrderChange(workId, operator,changeReason);
return getResult(aBoolean); return getResult(aBoolean);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment